Fix components in build-type: Custom packages
#2257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These components may depend on the `library` component of the package however `plan.json` does not include that dependency (since cabal will build all the components at once). This fix adds the library component as a dependency of the other components.
hamishmack
added a commit
that referenced
this pull request
Oct 8, 2024
This is an alternative to #2257 that is probably closer to the `cabal-install` behaviour. It also has the advantage of removing the special case for `cabal-doctest`.
pranaysashank
pushed a commit
to kronor-io/haskell.nix
that referenced
this pull request
Jan 18, 2025
* Fix components in `build-type: Custom` packages These components may depend on the `library` component of the package however `plan.json` does not include that dependency (since cabal will build all the components at once). This fix adds the library component as a dependency of the other components. * ifdLevel 1 * Add comment and only include library if there is one. * ifdLevel 2 * ifdLevel 3 * Fix broken test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These components may depend on the
librarycomponent of the package howeverplan.jsondoes not include that dependency (since cabal will build all the components at once). This fix adds the library component as a dependency of the other components.